Bugfix: ConfigDict.user_values() should return only child entries, not instance itself#3722
Merged
blnicho merged 4 commits intoPyomo:mainfrom Oct 14, 2025
Merged
Bugfix: ConfigDict.user_values() should return only child entries, not instance itself#3722blnicho merged 4 commits intoPyomo:mainfrom
ConfigDict.user_values() should return only child entries, not instance itself#3722blnicho merged 4 commits intoPyomo:mainfrom
Conversation
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3722 +/- ##
==========================================
- Coverage 89.31% 89.16% -0.15%
==========================================
Files 896 896
Lines 103698 103701 +3
==========================================
- Hits 92620 92470 -150
- Misses 11078 11231 +153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Simplify preservation of Config.userSet during initialization
jsiirola
approved these changes
Oct 13, 2025
github-project-automation
bot
moved this from Todo
to Reviewer Approved
in Pyomo 6.9.5 Release
Contributor
Author
|
Jenkins failures were related to #3750 , unrelated to anything else. So this is technically good to go. |
github-project-automation
bot
moved this from Reviewer Approved
to Done
in Pyomo 6.9.5 Release
shermanjasonaf
added a commit
to shermanjasonaf/pyomo
that referenced
this pull request
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3721
Summary/Motivation:
@shermanjasonaf reported an issue with
ConfigDict.user_values(). This PR fixes that problem by introducing a new private flag and adds two tests that mimic the examples given in the Issue.Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: