Ensure PyROS Supports Problems Containing No Variables/Uncertain Parameters#3720
Merged
jsiirola merged 11 commits intoPyomo:mainfrom Oct 3, 2025
Merged
Conversation
Contributor
Author
blnicho
approved these changes
Sep 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3720 +/- ##
=======================================
Coverage 89.31% 89.31%
=======================================
Files 896 896
Lines 103682 103684 +2
=======================================
+ Hits 92605 92607 +2
Misses 11077 11077
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsiirola
reviewed
Sep 19, 2025
Member
jsiirola
left a comment
jsiirola
left a comment
There was a problem hiding this comment.
Looks pretty good. One implementation change that would be nice, and maybe a little more information in the warnings?
Co-authored-by: John Siirola <[email protected]>
blnicho
approved these changes
Sep 24, 2025
jsiirola
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
As an example from #2555 suggests, PyROS is (now) capable of solving RO models that do not have variables appearing in the model's active objective or constraints. However, PyROS currently raises an exception if the user-supplied arguments
first_stage_variablesandsecond_stage_variablesare (cast to) empty lists.Further, PyROS is also capable of solving problems that have no uncertain parameters (efficiently, as of #3503). However, this is not (fully) checked in the testing modules.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: