Validate an argument using the new api_version() method, also implement that method on wrapper classes#3717
Merged
mrmundt merged 3 commits intoPyomo:mainfrom Sep 9, 2025
Merged
Conversation
mrmundt
approved these changes
Sep 9, 2025
Contributor
mrmundt
left a comment
mrmundt
left a comment
There was a problem hiding this comment.
We had a quick chat about this at the dev call, and the implementation is perfectly fine. I just had a residual question that I wanted answered.
emma58
approved these changes
Sep 9, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3717 +/- ##
=======================================
Coverage 89.31% 89.31%
=======================================
Files 896 896
Lines 103670 103675 +5
=======================================
+ Hits 92589 92594 +5
Misses 11081 11081
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # n/a
Summary/Motivation:
#3699 created a new api_version() method that can be queried to determine which api version a solver object supports. Use that method to validate a solver object argument in multiple_bigm.py, rather than using
isinstancein a questionable way.Along the way I noticed that contrib LegacySolverWrapper and appsi LegacySolverInterface class instances were returning V2 and APPSI as their api versions which is not correct, so I added an override to api_version() there.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: