Merged
Conversation
update the fork
jsiirola
requested changes
Sep 4, 2025
Member
jsiirola
left a comment
jsiirola
left a comment
There was a problem hiding this comment.
This is great - and needed. Please:
- reorder the set entries to match the column order from https://www.gams.com/latest/docs/S_MAIN.html#SOLVERS_MODEL_TYPES
- verify the set matches those docs (I believe that RNLP is missing)
- [bonus] would you mind going through that table and verifying the other solvers, too (and add any missing entries)?
Contributor
Author
|
I have reordered the set entries and added missing solvers. |
jsiirola
approved these changes
Sep 16, 2025
Member
|
We should probably:
But, I am fine deferring these for a subsequent PR. |
mrmundt
approved these changes
Sep 29, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3714 +/- ##
==========================================
+ Coverage 89.31% 89.32% +0.01%
==========================================
Files 896 896
Lines 103687 103687
==========================================
+ Hits 92609 92621 +12
+ Misses 11078 11066 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # None
Summary/Motivation:
Previously, the configuration did not account for the use of NLP and MINLP when Gurobi was selected as a subsolver within GAMS. This PR ensures that these problem types are properly recognized and supported.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: