Merged
Conversation
mrmundt
approved these changes
Aug 12, 2025
Contributor
mrmundt
left a comment
There was a problem hiding this comment.
Thanks for fixing this so quickly!
jsiirola
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3690
Summary/Motivation:
#3690 reported a bug in the simulator where if you had a differential equation of the form
A*dxdt + B == RHSit would be handled differently thandxdt*A + B == RHS. Pyomo.DAE checks for certain forms that a differential equation may have been written in and tries to permute those forms to a standard separable format expected by the integrators. At one point I think product expressions would have been rearranged such that ifAwas not potentially variable it would have ALWAYS been moved toarg[0]in theProductExpressionso the Simulator only ever checked forA*dxdt. When we stopped doing automatic expression mangling in core Pyomo the assumption that the simulator didn't have to check fordxdt*Awas no longer valid and the bug was introduced. This PR fixes it by ensuring the Simulator is checking for both cases.Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: