Add reporting of SCIP node count to solver results#3691
Merged
mrmundt merged 3 commits intoPyomo:mainfrom Aug 25, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3691 +/- ##
==========================================
+ Coverage 89.19% 89.21% +0.01%
==========================================
Files 892 892
Lines 103015 103215 +200
==========================================
+ Hits 91888 92081 +193
- Misses 11127 11134 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrmundt
approved these changes
Aug 12, 2025
github-project-automation
bot
moved this from Todo
to Reviewer Approved
in Pyomo 6.9.4 Release
anatoliy-kuznetsov
force-pushed
the
scip-nodes
branch
from
051bf66 to
8961c0e
Compare
Contributor
Author
|
squashed commits to have a better message and less clutter |
emma58
reviewed
Aug 19, 2025
Contributor
emma58
left a comment
emma58
left a comment
There was a problem hiding this comment.
I have one naming suggestion, but otherwise this looks good.
|
|
||
| results.solver.time = log_dict['solving_time'] | ||
| results.solver.gap = log_dict['gap'] | ||
| results.solver.nodes = log_dict['solving_nodes'] |
Contributor
There was a problem hiding this comment.
I think results.solver.node_count might be a clearer name, but I don't have super strong feelings about it.
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion! I've made this change.
blnicho
approved these changes
Aug 21, 2025
github-project-automation
bot
moved this from Reviewer Approved
to Done
in Pyomo 6.9.4 Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
N/A
Summary/Motivation:
When running
pyomo solvewith the SCIP solver, the serialized results files don't show the number of nodes explored. The SCIPAMPL handler parses the number of nodes in the SCIP solver log and returns it fromread_scip_log, but not in the solver results returned from_postsolve. Including it would make it easier to assess changes in tree size when benchmarking.Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: