Added support for Highs solver in contrib.Benders#3686
Added support for Highs solver in contrib.Benders#3686blnicho merged 1 commit intoPyomo:mainfrom viens-code:solvers_for_benders
Conversation
Highs follows the general dual sign convention as the rest of the solvers. Applied the same tests as the rest of the LP solvers and it passes
blnicho
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3686 +/- ##
=======================================
Coverage 89.20% 89.20%
=======================================
Files 892 892
Lines 102978 102979 +1
=======================================
+ Hits 91857 91860 +3
+ Misses 11121 11119 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsiirola
left a comment
jsiirola
left a comment
There was a problem hiding this comment.
I don't have a problem with this PR; however, I should note that this doesn't actually test that HiGHS works as a solver. I am comfortable deferring that to a more comprehensive overhaul of this package in a future PR.
| for mip_name in ( | ||
| 'cplex_direct', | ||
| 'gurobi_direct', | ||
| 'gurobi', | ||
| 'cplex', | ||
| 'glpk', | ||
| 'cbc', | ||
| 'highs', | ||
| ): | ||
| mip_available = pyo.SolverFactory(mip_name).available(exception_flag=False) | ||
| if mip_available: | ||
| break |
There was a problem hiding this comment.
This isn't actually running tests against each of these solvers. It just picks the first available solver. Is that the intended behavior?
There was a problem hiding this comment.
That was not what I intended no.
Due to the MPI linkage and the original tests being designed (in my understanding) for the MPI-SPPY use, I want to keep the tweaks to the tests and code as minimal as possible.
I did test it as just running highs locally.
Planning a larger PR that will overhaul this package and will add more tests then.
4 participants
Fixes #3684
Summary/Motivation:
Add the ability to use the Highs solver in contrib.Benders.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: