Skip to content

Resolve bugs when comparing results objects to other types#3677

Merged
blnicho merged 2 commits intoPyomo:mainfrom
jsiirola:container-eq-fix
Aug 5, 2025
Merged

Resolve bugs when comparing results objects to other types#3677
blnicho merged 2 commits intoPyomo:mainfrom
jsiirola:container-eq-fix

Conversation

@jsiirola
Copy link
Copy Markdown
Member

@jsiirola jsiirola commented Aug 5, 2025

Fixes # .

Summary/Motivation:

IDAES integration tests pointed out the new implementation of MapContainer.__eq__ was fragile and would fail when comparing results objects to other (slotized) types. This PR resolves those errors and improves container testing.

Changes proposed in this PR:

  • Catch cases when comparing Container objects to non-Container objects.
  • Add additional tests

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@blnicho blnicho merged commit adc610b into Pyomo:main Aug 5, 2025
35 checks passed
@jsiirola jsiirola deleted the container-eq-fix branch August 8, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants