NL writer: resolve model scaling bug writing Expression objects#3673
Merged
blnicho merged 2 commits intoPyomo:mainfrom Aug 4, 2025
Merged
NL writer: resolve model scaling bug writing Expression objects#3673blnicho merged 2 commits intoPyomo:mainfrom
Expression objects#3673blnicho merged 2 commits intoPyomo:mainfrom
Conversation
mrmundt
approved these changes
Aug 4, 2025
blnicho
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
@dallan-keylogic found a particularly nefarious bug where turning on the handling of scaling in the NLv2 writer would fail to scale the linear coefficients of named expressions (
Expressioncomponents) used in nonlinear contexts. This PR resolves the bug and adds a test for scaling namedExpressionobjects in nonlinear contexts (slightly modified from @dallan-keylogic's MWE).Changes proposed in this PR:
_write_v_lineto scale the linear term coefficients.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: