Bugfixes for core.lp_dual transformation#3672
Merged
blnicho merged 19 commits intoPyomo:mainfrom Aug 6, 2025
Merged
Conversation
…bles to be constants even if we're intending to parameterize by them
…ver the parameterize_wrt list
…that became trivial for the paramterization and raising an error because I think it is extremely unlikely this is what the user meant to do, and even if it was, they don't gain anything by it.
… to check for a row of all 0's, using said efficient way to improve the checking for trivial constraints due to parameterization in the lp dual
jsiirola
approved these changes
Aug 6, 2025
Member
jsiirola
left a comment
There was a problem hiding this comment.
Looks good. Two comments that we should consider (but it is fine to leave them for a future PR).
|
|
||
| return dense | ||
|
|
||
| def tocsr(self): |
Member
There was a problem hiding this comment.
We ought to follow scipy's lead and only implement a single method that tocsr and tocsc both use (instead of virtually duplicate code)
blnicho
approved these changes
Aug 6, 2025
Member
blnicho
left a comment
There was a problem hiding this comment.
I found a few typos but otherwise this looks fine
Co-authored-by: John Siirola <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
NOTE: This is built on top of #3651, so it will be impossible to review until that is merged.
This fixes a couple bugs in the
core.lp_dualtransformation. In particular:(whatever that means) is rather unexpected, I think.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: