Introduce Retries into download-extensions#3656
Merged
mrmundt merged 5 commits intoPyomo:mainfrom Jul 8, 2025
Merged
Conversation
blnicho
approved these changes
Jul 8, 2025
Member
|
I realize this is merged, but is this the right place to put the retry? I would have thought a better place to put retries is in our test drivers, under the theory that the downloaded should just download and any retries should be left to the driver (much like curl and wget don’t retry automatically). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes N/A
Summary/Motivation:
I'm personally losing my mind w.r.t.
download-extensionsbecausegjhis somewhat unreliable lately when downloading (but then will sometimes be fine if you try again). This introduces retries (default 3) intodownload-extensionswith a short sleep of 1 second between each one.Changes proposed in this PR:
download-extensionLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: