Adjust PyROS handling of separation objective evaluation errors#3646
Merged
jsiirola merged 4 commits intoPyomo:mainfrom Jul 19, 2025
Merged
Adjust PyROS handling of separation objective evaluation errors#3646jsiirola merged 4 commits intoPyomo:mainfrom
jsiirola merged 4 commits intoPyomo:mainfrom
Conversation
1 task
mrmundt
approved these changes
Jul 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3646 +/- ##
==========================================
- Coverage 88.94% 88.87% -0.07%
==========================================
Files 888 889 +1
Lines 102444 104721 +2277
==========================================
+ Hits 91115 93067 +1952
- Misses 11329 11654 +325
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Miranda Mundt <[email protected]>
jsiirola
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
Upon the solution of a separation problem, PyROS attempts to evaluate the violations of all second-stage inequality constraints at the optimal solution to that separation problem. In (rare) cases, the evaluation may fail due to an exception encountered/raised by the Pyomo expression evaluators. This exception may be of type
ValueErrororArithmeticError. Currently, PyROS does not handle an exception of typeArithmeticErrorand handles aValueError-type exception as follows:ArithmeticErrorwith a message of the form "Evaluation . . . of constraint . . . led to a math domain error. Does the constraint contain . . . functions . . . with tricky domains?"In this PR, we modify PyROS to handle an exception of type
ValueErrororArithmeticErroras follows:Changes proposed in this PR:
See above.
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: