Bug fixes in the current parmest.py and example files#3635
Bug fixes in the current parmest.py and example files#3635blnicho merged 7 commits intoPyomo:mainfrom
Conversation
…in test_parmest.py file
|
@adowling2 @djlaky @mrmundt @jsiirola I fixed the |
|
@slilonfe5 Did you address all of the feedback? Is this ready for final review? |
|
@adowling2 @djlaky @jsiirola @mrmundt I have addressed the feedback from John. This PR is ready for final review. |
|
@slilonfe5 did you see the review comments I left you a couple days ago? Let me know if you have any questions. |
|
@blnicho Yes. Thank you for your feedback. I'm working on them now |
mrmundt
left a comment
There was a problem hiding this comment.
A little comment - I think this is very close to ready.
|
@mrmundt @blnicho @jsiirola @adowling2 @djlaky I have implemented the feedback from the final review. This PR is ready to be merged into the Pyomo main. I will move this to "Done" in the ParmEst & Pyomo.DoE Development board. A kind reminder that this PR needs to be merged into the Pyomo main to enable PR #3535 to go through. Thank you |
Fixes # .
Summary/Motivation:
There is a raise error bug in the checks for
experiment_outputsandunknown_parametersin the current parmest.py file: it fails to raise an error when the pyomo model used in the parmest example files lacks these attributes.Changes proposed in this PR:
raisein the try and except code that checks forexperiment_outputsandunknown_parametersin the current parmest.py fileexperiment_outputsattribute to the pyomo model of the parmest examples that lack this attributeLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: