Skip to content

Temporarily pinning the scikit-learn and Python 3.13 versions#3625

Merged
mrmundt merged 4 commits intoPyomo:mainfrom
blnicho:pin-sklearn
Jun 16, 2025
Merged

Temporarily pinning the scikit-learn and Python 3.13 versions#3625
mrmundt merged 4 commits intoPyomo:mainfrom
blnicho:pin-sklearn

Conversation

@blnicho
Copy link
Copy Markdown
Member

@blnicho blnicho commented Jun 13, 2025

Fixes # .

Summary/Motivation:

This sets an upper limit on the scikit-learn version to work around testing failures in contrib.piecewise stemming from the unmaintained linear-tree package. @emma58 is working on a better solution that will replace the linear-tree dependency with something that is being maintained. This PR is a temporary fix until then.

Upon opening this PR we also discovered a new testing issue with cpython 3.13.4. This new Python version introduces a slight change in the formatting of some logging messages which we've tracked to this resolved issue: python/cpython#91555. We need feedback from @jsiirola on how to proceed.

Changes proposed in this PR:

  • Temporarily bound scikit-learn version
  • Temporarily pin Python 3.13 version used for testing

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@blnicho blnicho requested a review from mrmundt June 13, 2025 15:23
@blnicho blnicho changed the title Temporarily pinning the version scikit-learn Temporarily pinning the scikit-learn version Jun 13, 2025
@blnicho blnicho changed the title Temporarily pinning the scikit-learn version Temporarily pinning the scikit-learn and Python 3.13 versions Jun 13, 2025
@jsiirola
Copy link
Copy Markdown
Member

I think it is fine to merge this as-is to get tests passing and to free up the PR backlog. I will start looking into what changed in Python 3.13.4, but that will take longer and I don't think we should hold up everything else waiting for it.

@mrmundt mrmundt merged commit dc503c2 into Pyomo:main Jun 16, 2025
62 of 63 checks passed
@blnicho blnicho deleted the pin-sklearn branch December 1, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants