Temporarily pinning the scikit-learn and Python 3.13 versions#3625
Merged
mrmundt merged 4 commits intoPyomo:mainfrom Jun 16, 2025
Merged
Temporarily pinning the scikit-learn and Python 3.13 versions#3625mrmundt merged 4 commits intoPyomo:mainfrom
mrmundt merged 4 commits intoPyomo:mainfrom
Conversation
mrmundt
approved these changes
Jun 13, 2025
…3.4 that broke some logging tests
mrmundt
approved these changes
Jun 13, 2025
jsiirola
approved these changes
Jun 16, 2025
Member
|
I think it is fine to merge this as-is to get tests passing and to free up the PR backlog. I will start looking into what changed in Python 3.13.4, but that will take longer and I don't think we should hold up everything else waiting for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
This sets an upper limit on the scikit-learn version to work around testing failures in
contrib.piecewisestemming from the unmaintainedlinear-treepackage. @emma58 is working on a better solution that will replace thelinear-treedependency with something that is being maintained. This PR is a temporary fix until then.Upon opening this PR we also discovered a new testing issue with cpython 3.13.4. This new Python version introduces a slight change in the formatting of some logging messages which we've tracked to this resolved issue: python/cpython#91555. We need feedback from @jsiirola on how to proceed.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: