Skip to content

Minor numpy2 compatibility / testing cleanup#3607

Merged
jsiirola merged 6 commits intoPyomo:mainfrom
jsiirola:testing-cleanup
May 21, 2025
Merged

Minor numpy2 compatibility / testing cleanup#3607
jsiirola merged 6 commits intoPyomo:mainfrom
jsiirola:testing-cleanup

Conversation

@jsiirola
Copy link
Copy Markdown
Member

@jsiirola jsiirola commented May 20, 2025

Fixes # .

Summary/Motivation:

This PR resolves a number of minor problems:

  • This cleans up the driver for testing the Kernel examples (move it to use some of the utilities from pyomo.common and streamline the definition of the test cases).
  • This removes GLPK direct from the test driver (the interface was removed from Pyomo a long time ago)
  • This resolves warnings generated by NumPy within the AMPL repn compiler
  • This makes the IndexedComponent __array__ interface compatible with the NumPy2 API

Changes proposed in this PR:

  • (see above)

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

mrmundt
mrmundt reviewed May 20, 2025
View reviewed changes
@codecov
Copy link
Copy Markdown

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.85%. Comparing base (18def95) to head (c538d53).
⚠️ Report is 923 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3607      +/-   ##
==========================================
+ Coverage   88.83%   88.85%   +0.02%     
==========================================
  Files         889      888       -1     
  Lines      102205   102131      -74     
==========================================
- Hits        90792    90752      -40     
+ Misses      11413    11379      -34
Flag Coverage Δ
builders 26.65% <10.00%> (+<0.01%) ⬆️
default 84.97% <100.00%> (?)
expensive 34.03% <10.00%> (?)
linux 86.64% <100.00%> (-1.93%) ⬇️
linux_other 86.64% <100.00%> (+0.02%) ⬆️
osx 82.93% <90.00%> (+0.01%) ⬆️
win 84.84% <100.00%> (+0.02%) ⬆️
win_other 84.84% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsiirola jsiirola merged commit 7d8e631 into Pyomo:main May 21, 2025
35 checks passed
@jsiirola jsiirola deleted the testing-cleanup branch May 21, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrmundt mrmundt mrmundt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jsiirola @mrmundt