Suppress warmstart message from Xpress#3599
Merged
mrmundt merged 2 commits intoPyomo:mainfrom May 13, 2025
Merged
Conversation
mrmundt
reviewed
May 7, 2025
Co-authored-by: Miranda Mundt <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3599 +/- ##
==========================================
- Coverage 88.76% 88.76% -0.01%
==========================================
Files 891 891
Lines 102297 102303 +6
==========================================
+ Hits 90802 90805 +3
- Misses 11495 11498 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrmundt
approved these changes
May 13, 2025
jsiirola
approved these changes
May 13, 2025
Member
jsiirola
left a comment
jsiirola
left a comment
There was a problem hiding this comment.
Tests would be nice, but given that we are moving away from this interface, I don't think they are required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # N/A
Summary/Motivation:
On
main, when usingwarmstart = Truewith Xpress, you will always see the below message printed to the screen:which is emitted by the
addmipsolmethod ofxpress.problem. This can be troublesome because (1) the message is printed to the screen unconditionally and (2) does not end up in a specifiedlogfile.Changes proposed in this PR:
XpressDirect._warm_startuntil the model is about to be solved, when thelogfileand / orteeattributes have been properly configured.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: