Resolve GAMS/Windows logfile name issue#3595
Merged
mrmundt merged 17 commits intoPyomo:mainfrom May 6, 2025
Merged
Conversation
jsiirola
reviewed
May 6, 2025
Member
jsiirola
left a comment
jsiirola
left a comment
There was a problem hiding this comment.
Two relatively minor nits and one question.
jsiirola
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3579
Summary/Motivation:
It was reported in #3579 that there are issues in GAMS on Windows when a path has spaces. This PR resolves that (and it was, in fact, a pretty tricky little thing to resolve. GAMS + subprocess on Windows is a bit of a bear.)
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: