CSpline - Fix segment function and add utils to constrain parameter calculations#3593
Merged
blnicho merged 15 commits intoPyomo:mainfrom Jun 3, 2025
Merged
CSpline - Fix segment function and add utils to constrain parameter calculations#3593blnicho merged 15 commits intoPyomo:mainfrom
blnicho merged 15 commits intoPyomo:mainfrom
Conversation
mrmundt
reviewed
May 6, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3593 +/- ##
==========================================
+ Coverage 88.83% 88.85% +0.01%
==========================================
Files 888 888
Lines 102172 102338 +166
==========================================
+ Hits 90767 90932 +165
- Misses 11405 11406 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsiirola
reviewed
May 13, 2025
Contributor
|
FYI that there is a pretty silly false positive in the typos check right now that I am hoping they'll do a hot patch to fix. I'm monitoring the PR that their team opened (crate-ci/typos#1311) |
mrmundt
requested changes
Jun 2, 2025
added 3 commits
June 2, 2025 18:18
mrmundt
approved these changes
Jun 3, 2025
Contributor
mrmundt
left a comment
mrmundt
left a comment
There was a problem hiding this comment.
The new class CubicParametersModelData probably should have some more unit tests, but I won't let that hold up this PR.
blnicho
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
There was a bug in the segment function in the parameter class. The function is just used for testing and plotting cubic splines, so it is not likely to have affected anything. It's fixed and tests are added that would catch similar future issues.
Summary/Motivation:
This fixes a bug and adds parameter calculation options that allow you to impose certain properties on the cubic spline.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: