Conversation
michaelbynum
left a comment
michaelbynum
left a comment
There was a problem hiding this comment.
A couple minor comments. Yay for improved type hints!
|
Oh, is there a copy of the log parsing code in parmest that needs to be removed? |
I'm hesitant to remove anything from parmest because I don't know how it's being used outside of Pyomo (e.g., it might be "the thing" that people are using to parse IPOPT output in other places). I figure it's something we can either (a) leave because it does no harm or (b) remove in the future with a fair deprecation warning. |
| # Set iteration_log visibility to ADVANCED_OPTION because it's | ||
| # a lot to print out with `display` | ||
| results.extra_info.get("iteration_log")._visibility = ( | ||
| ADVANCED_OPTION | ||
| ) |
There was a problem hiding this comment.
Why is this not just set when it is originally created?
There was a problem hiding this comment.
Because it's implicitly declared. Is there a different way to do it in that scenario?
There was a problem hiding this comment.
We should probably make a public API for changing the visibility, then.
There was a problem hiding this comment.
Fine with me but not part of this PR.
3 participants
Fixes #548, #728 , IDAES/idaes-pse#92
Summary/Motivation:
There is a utility wrapper in parmest that gathers helpful data from the IPOPT log that has never been promoted to a "real world citizen." This PR replaces the need for that in
ipopt_v2by parsing the output and storing important data by default on theResultsobject.NOTE: This PR contains #3576 so that one needs to be merged first.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: