Skip to content

Add some pynumero-based sensitivity functions#3561

Merged
blnicho merged 14 commits intoPyomo:mainfrom
eslickj:sens
Jul 3, 2025
Merged

Add some pynumero-based sensitivity functions#3561
blnicho merged 14 commits intoPyomo:mainfrom
eslickj:sens

Conversation

@eslickj
Copy link
Copy Markdown
Contributor

@eslickj eslickj commented Apr 14, 2025

Fixes None

Add a couple pynumero-based sensitivity functions to the sensitivity toolbox function.

Summary/Motivation:

This provides some alternative sensitivity calculations based on pynumero

Changes proposed in this PR:

  • and ability to calculate sensitivity using pynumero

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@adowling2
Copy link
Copy Markdown
Member

adowling2 commented Apr 15, 2025

Adding a note for me to look at this!

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.72%. Comparing base (d1a507f) to head (52604ae).
Report is 130 commits behind head on main.

Files with missing lines Patch % Lines
pyomo/contrib/sensitivity_toolbox/pynumero.py 95.12% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #3561    +/-   ##
========================================
  Coverage   88.72%   88.72%            
========================================
  Files         889      891     +2     
  Lines      102145   102448   +303     
========================================
+ Hits        90626    90902   +276     
- Misses      11519    11546    +27
Flag Coverage Δ
builders 26.57% <19.51%> (+<0.01%) ⬆️
default 84.84% <95.12%> (?)
expensive 33.96% <19.51%> (?)
linux 86.20% <95.12%> (-2.27%) ⬇️
linux_other 86.20% <95.12%> (-0.04%) ⬇️
osx 76.20% <95.12%> (+0.01%) ⬆️
win 84.73% <95.12%> (+<0.01%) ⬆️
win_other 84.73% <95.12%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaelbynum michaelbynum self-assigned this Apr 15, 2025
@adowling2 adowling2 mentioned this pull request Apr 15, 2025
Open
@blnicho blnicho requested review from blnicho and michaelbynum April 29, 2025 18:52
eslickj
eslickj commented Jun 3, 2025
View reviewed changes
pyomo/contrib/sensitivity_toolbox/pynumero.py
from pyomo.common.collections import ComponentSet, ComponentMap


def _coo_reorder_cols(mat, remap):
Copy link
Copy Markdown
Contributor Author

@eslickj eslickj Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: I found this can cause Python to just quit without an error message if you try to remap columns outside the matrix (like if the matrix has 4 columns and you try to move a column to the 6th column or move the 6th column that doesn't exist). At least probably should add a shape check. May want to rethink this.

@adowling2 adowling2 mentioned this pull request Jun 4, 2025
Open
@blnicho blnicho moved this from Todo to Review In Progress in August 2025 Release Jun 23, 2025
@github-project-automation github-project-automation bot moved this from Review In Progress to Reviewer Approved in August 2025 Release Jul 1, 2025
@mrmundt
Copy link
Copy Markdown
Contributor

mrmundt commented Jul 1, 2025

@eslickj - There are some unguarded uses of scipy that need to be addressed in the tests. That's the reason behind the slim/pypy failures.

blnicho
blnicho reviewed Jul 1, 2025
View reviewed changes
blnicho
blnicho reviewed Jul 2, 2025
View reviewed changes
blnicho
blnicho reviewed Jul 2, 2025
View reviewed changes
@blnicho blnicho merged commit 926c91a into Pyomo:main Jul 3, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in August 2025 Release Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blnicho blnicho blnicho approved these changes

@mrmundt mrmundt mrmundt approved these changes

@michaelbynum michaelbynum Awaiting requested review from michaelbynum

Assignees

@michaelbynum michaelbynum

Labels

None yet

Projects

No open projects
August 2025 Release
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@eslickj @adowling2 @mrmundt @blnicho @jsiirola @michaelbynum @pyomo-autotest