Remove loud deprecation warning in contrib.solver#3555
Merged
mrmundt merged 7 commits intoPyomo:mainfrom Apr 9, 2025
Merged
Conversation
mrmundt
changed the title
contrib.solverscontrib.solver
jsiirola
reviewed
Apr 9, 2025
Comment on lines
+316
to
+317
| The new interface has condensed ``LegacySolverStatus``, | ||
| ``LegacyTerminationCondition``, and ``LegacySolutionStatus`` into |
Member
There was a problem hiding this comment.
These should not have "Legacy" - that was an artifact of how you were importing those objects into the module. I think it should be a reference to teh old classes (e.g., like :py:class:`pyomo.opt.results.solution.SolutionStatus` )
jsiirola
reviewed
Apr 9, 2025
jsiirola
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NA
Summary/Motivation:
We put in a loud deprecation warning for the legacy results map that is more obnoxious than helpful. This moves the information to RTD instead. (Also this "upgrades" solution_loader to a developer option because it's generally not helpful to show by default on the results object)
Changes proposed in this PR:
solution_loadertoDEVELOPER_OPTIONLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: