Merged
Conversation
mrmundt
reviewed
Mar 26, 2025
mrmundt
approved these changes
Mar 26, 2025
Contributor
mrmundt
left a comment
mrmundt
left a comment
There was a problem hiding this comment.
I think it's missing a comma for grammatical-correctness but this looks great.
Co-authored-by: Miranda Mundt <[email protected]>
blnicho
approved these changes
Mar 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3542 +/- ##
=======================================
Coverage 88.70% 88.70%
=======================================
Files 888 888
Lines 101963 101963
=======================================
+ Hits 90446 90450 +4
+ Misses 11517 11513 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
This adds missing documentation for BlockData.clone(), motivated by answering a SO question
Changes proposed in this PR:
BlockData.clone()Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: