calc_variable_from_constraint: guard against expression overflow #3541
Merged
jsiirola merged 2 commits intoPyomo:mainfrom Mar 28, 2025
Merged
calc_variable_from_constraint: guard against expression overflow #3541jsiirola merged 2 commits intoPyomo:mainfrom
calc_variable_from_constraint: guard against expression overflow #3541jsiirola merged 2 commits intoPyomo:mainfrom
Conversation
Robbybp
approved these changes
Mar 27, 2025
Contributor
Robbybp
left a comment
There was a problem hiding this comment.
FBBT may be nice as well, but I see no reason not to do this.
michaelbynum
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3540 .
Summary/Motivation:
This adds additional guards to
calculate_variable_from_constraint()to catchOverflowErrorexceptions when evaluating the constraint during the initial linear test and during the line search.Changes proposed in this PR:
OverflowErrorexceptions during function evaluationsLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: