Address intermittent TeeStream test failure#3465
Merged
blnicho merged 3 commits intoPyomo:mainfrom Feb 5, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3465 +/- ##
==========================================
+ Coverage 88.19% 88.66% +0.47%
==========================================
Files 880 880
Lines 100594 101307 +713
==========================================
+ Hits 88715 89827 +1112
+ Misses 11879 11480 -399
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mrmundt
approved these changes
Feb 5, 2025
blnicho
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
This makes an attempt at addressing an intermittent test failure in the TeeStream buffering tests. We are occasionally seeing instances where
pyomo/common/tests/test_tee.py::TestBuffering_noCapture::test_buffered_stdout_flushfails because theflush()does not appear to actually flush the output stream. This PR doesn't actually fix the underlying issue and instead adds an automatic retry before failing the test.Changes proposed in this PR:
pyomo/common/tests/test_tee.py::TestBuffering_noCapture::test_buffered_stdout_flushif the first attempt would have led to a failure.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: