Resolve buffering issues in TeeStream and capture_output#3449
Merged
mrmundt merged 26 commits intoPyomo:mainfrom Feb 4, 2025
Merged
Resolve buffering issues in TeeStream and capture_output#3449mrmundt merged 26 commits intoPyomo:mainfrom
TeeStream and capture_output#3449mrmundt merged 26 commits intoPyomo:mainfrom
Conversation
|
Would love to see this resolved. |
Contributor
Thanks! We have been having lots of issues with our testing infrastructure that we need to fix before we can get any actually functional PRs merged. Stay tuned! |
mrmundt
reviewed
Feb 4, 2025
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class _SignalFlush(object): |
Comment on lines
+115
to
+116
| # NOTE: do not flush: we will test flush in the next test | ||
| # t.STDOUT.flush() |
mrmundt
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3084, fixes #3031, fixes #2845.
Summary/Motivation:
The HiGHS interface exposed some issues in the logic in
TeeStreamandcapture_outputwhere the two could end up fighting with each other. This PR should resolve all issues with console log management that we have been seeing with HiGHS.Changes proposed in this PR:
TeeStreamhandle is propagated through tho the target output streamsTeeStreamtocapture_outputto prevent ending up with nestedTeeStreaminstancesTeeStreamshoulddupall target file descriptors so that subsequent context managers (likecapture_output) don't commandeer them (causing a weird circular reference loop)capture_outputhandles redirection (do not letredirect_fdupdate thesys.stdout/sys.stderrstreams)TeeStream(andcapture_output)capture_output/TeeStreamfor managing the console output.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: