Resolve incompatibility between imp and the DeferredImportCallbackFinder#3444
Merged
jsiirola merged 4 commits intoPyomo:mainfrom Dec 6, 2024
Merged
Resolve incompatibility between imp and the DeferredImportCallbackFinder#3444jsiirola merged 4 commits intoPyomo:mainfrom
imp and the DeferredImportCallbackFinder#3444jsiirola merged 4 commits intoPyomo:mainfrom
Conversation
|
I tested the notebook (static link, Colab link) where the issue was originally noticed, making sure a new "runtime" (container instance) was used each time. Without the fix (Pyomo 6.8.2)With the fix (installing Pyomo from this PR's head branch before importing it) |
blnicho
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes # .
Summary/Motivation:
IDAES identified an incompatibility with Pyomo's
DeferredImportCallbackFinderand the (deprecated)impmodule. Finders from that module lack afind_specmethod and instead use afind_modulemethod.This came up because Google Collab defines
imp-style finders, which was causing errors: https://ndcbe.github.io/optimization/notebooks/7/degeneracy_hunter.htmlChanges proposed in this PR:
impandimportlibstyle findersLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: