Summary/Motivation:

PyROS currently terminates with a subsolver_error status when user-supplied sub-solvers fail to successfully solve a separation problem. However, the PyROS algorithm can potentially recover from these separation problem sub-solver errors by moving to the next iteration using violated constraints from the set of successfully solved separation problems. Here, PyROS should continue solving as long as constraint violations are found and either terminate successfully (if the final iteration contains no subsolver_error) or terminate with subsolver_error (if the final iteration contains a subsolver_error and no performance constraints are violated). This efficiency may improve PyROS's robustness and help to successfully solve problems that currently terminate immediately with subsolver_error.

Changes proposed in this PR:

• Update SeparationLoopResults.subsolver_error to check if violations were found in the separation loop. subsolver_error=True for the separation loop only when no other violations are found.
• Update DiscreteSeparationSolveCallResult.subsolver_error to check if all scenarios had subsolver_error. subsolver_error=True only if all scenarios failed to solve.
• Update discrete_solve and get_worst_discrete_separation_solution to handle potential sub-solver errors without causing PyROS to terminate immediately
• Add log warnings to report sub-solver errors and inform that PyROS will continue to solve if a violation is found.
• Add unit tests for continuous and discrete uncertainty sets in TestPyROSSubsolverErrorEfficiency

TODO (after #3439 merged)

• Update version number and changelog

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

1. I agree my contributions are submitted under the BSD license.
2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.