Skip to content

Rename project "pyomo" in setup.py [PEP 625]#3430

Merged
blnicho merged 4 commits intoPyomo:mainfrom
jsiirola:rename-project
Mar 4, 2025
Merged

Rename project "pyomo" in setup.py [PEP 625]#3430
blnicho merged 4 commits intoPyomo:mainfrom
jsiirola:rename-project

Conversation

@jsiirola
Copy link
Copy Markdown
Member

@jsiirola jsiirola commented Nov 18, 2024

Fixes # .

Summary/Motivation:

PyPI is rejecting Pyomo wheels because the project name was capitalized. This resolves that error.

Changes proposed in this PR:

  • rename "Pyomo" -> "pyomo"

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@blnicho
Copy link
Copy Markdown
Member

blnicho commented Nov 19, 2024

I kicked off the wheel builder GHA workflow on this branch: https://github.com/blnicho/pyomo/actions/runs/11903047078

I'm not really sure how to check if these wheels satisfy PEP 625 or if we still need this PR since PyPI reverted the strict enforcement of the PEP.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.71%. Comparing base (038f38b) to head (be24275).
Report is 67 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3430      +/-   ##
==========================================
+ Coverage   88.66%   88.71%   +0.04%     
==========================================
  Files         882      882              
  Lines      100623   100623              
==========================================
+ Hits        89216    89265      +49     
+ Misses      11407    11358      -49
Flag Coverage Δ
linux 86.17% <ø> (+<0.01%) ⬆️
osx 76.19% <ø> (ø)
other 86.66% <ø> (+<0.01%) ⬆️
win 84.55% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blnicho
Copy link
Copy Markdown
Member

blnicho commented Jan 21, 2025

Closing this until it becomes a real problem again.

@blnicho blnicho closed this Jan 21, 2025
@jsiirola
Copy link
Copy Markdown
Member Author

jsiirola commented Feb 24, 2025

PyPI is now issuing warnings that they will start enforcing PEP625 "soon".

@jsiirola jsiirola reopened this Feb 24, 2025
@blnicho blnicho merged commit 6e8b973 into Pyomo:main Mar 4, 2025
34 checks passed
@jsiirola jsiirola deleted the rename-project branch March 24, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blnicho blnicho blnicho approved these changes

@mrmundt mrmundt mrmundt approved these changes

+1 more reviewer

@maurerle maurerle maurerle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jsiirola @blnicho @maurerle @mrmundt @pyomo-autotest