Merged
Conversation
jsiirola
previously requested changes
Nov 18, 2024
Member
There was a problem hiding this comment.
Please update the RST files to use :ref: directives and not full URLs (that will future-proof them)
Apart from that, this is fine, but I wonder if a better (long term) solution is for the Sphinx build to declare a |build| substitution variable (with rst_prolog) that resolves either to latest or stable so that the links automatically point to the correct location?
We might have to update the URL checker to recognize /expand those URLs though?
blnicho
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NA
Summary/Motivation:
There were a few missed URLs after the doc reorg that were pointing to
stable(which was officially updated as of last Friday when 6.8.1 came out).Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: