Skip to content

xpress_direct: resolve error retrieving reduced costs#3422

Merged
blnicho merged 2 commits intoPyomo:mainfrom
jsiirola:xpress-typo
Nov 18, 2024
Merged

xpress_direct: resolve error retrieving reduced costs#3422
blnicho merged 2 commits intoPyomo:mainfrom
jsiirola:xpress-typo

Conversation

@jsiirola
Copy link
Copy Markdown
Member

Fixes # .

Summary/Motivation:

Pyomo/mpi-sppy#451 pointed out a typo in the xpress_direct interface that prevented retrieving the reduced costs. This resolves that error and adds tests to exercise that functionality.

Changes proposed in this PR:

  • xpress_direct: fix typo (calling self._getRedCosts)
  • xpress_direct: add test for retrieving rc and slack Suffixes

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.72%. Comparing base (180924a) to head (03ec9d2).
Report is 272 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3422      +/-   ##
==========================================
+ Coverage   88.69%   88.72%   +0.03%     
==========================================
  Files         882      882              
  Lines      100615   100615              
==========================================
+ Hits        89237    89268      +31     
+ Misses      11378    11347      -31     
Flag Coverage Δ
linux 86.18% <100.00%> (+0.03%) ⬆️
osx 76.20% <100.00%> (+0.02%) ⬆️
other 86.68% <100.00%> (+0.03%) ⬆️
win 84.56% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blnicho blnicho merged commit ed495d6 into Pyomo:main Nov 18, 2024
@jsiirola jsiirola deleted the xpress-typo branch November 19, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants