Merged
Conversation
mrmundt
reviewed
Nov 11, 2024
mrmundt
approved these changes
Nov 11, 2024
… for all other embedded constants
blnicho
approved these changes
Nov 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3412 +/- ##
=======================================
Coverage 88.66% 88.66%
=======================================
Files 879 879
Lines 100374 100381 +7
=======================================
+ Hits 88999 89007 +8
+ Misses 11375 11374 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
This resolves an issue where AutoSlots was recording the temporary dict used to hold the class
__dict__in the memo (and then threw away the temporary dict). This was causing the deepcopy to corrupt the model in certain situations (IDAES models - but only on Windows with certain environments).The fix is to remove the temporary dict from the memo.
This PR also updates the ConfigBase / ConfigDict
__getstate__/__setstate__to avoid creating temporary tuples.Changes proposed in this PR:
__dict__dict in the deepcopy memoLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: