Resolve change in InvalidNumber handling in writers#3390
Merged
blnicho merged 7 commits intoPyomo:mainfrom Oct 31, 2024
Merged
Conversation
mrmundt
reviewed
Oct 28, 2024
Comment on lines
+64
to
+67
| def _inv2str(val): | ||
| return f"{val._str() if hasattr(val, '_str') else val}" | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Because this is exactly the same as lines 173-176 in pyomo/repn/ampl, wouldn't it make sense to instead put this in pyomo/repn/utils?
Member
Author
There was a problem hiding this comment.
Possibly? I didn't really want to advertise / test this as public functionality, but accessing "private" (underscored) objects from outside their module is also frowned upon. As the function was pretty trivial, I went with duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3386 .
Summary/Motivation:
This resolves #3386 by making it so that both
InvalidNumber.__str__andInvalidNumber.__repr__raise exceptions. It was relatively straightforward to remove the use of string conversions in the tests so that we no longer needed to cast InvalidNumber to a string.Note that this includes an exception to the "str(InvalidNumber) raises an exception rule: if we are in the middle of processing an exception, this does not raise another exception and instead returns the old string representation.
Changes proposed in this PR:
InvalidNumberso that bothstr()andrepr()raise exceptionsLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: