Resolve bugs in create_node_with_local_data#3376
Merged
jsiirola merged 4 commits intoPyomo:mainfrom Oct 9, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3376 +/- ##
=======================================
Coverage 88.63% 88.63%
=======================================
Files 879 879
Lines 100221 100223 +2
=======================================
+ Hits 88827 88832 +5
+ Misses 11394 11391 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mrmundt
approved these changes
Oct 4, 2024
Contributor
mrmundt
left a comment
mrmundt
left a comment
There was a problem hiding this comment.
This is clever, I like this.
emma58
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
IDAES/idaes-pse#1454 found bugs in
ExpressionData's implementation ofcreate_node_with_local_data(). In particular,ScalarExpression.create_node_with_local_datawas returning an unconstructedScalarExpression. This PR resolves that bug (and another found when debuggingcreate_node_with_local_data)Changes proposed in this PR:
ExpressionData.create_node_with_local_data: always return a bareExpressionDataobject, even if the original Expression was aScalarExpression.MonomialTermExpression.create_node_with_local_datawas ignoring the user-specified classtype argumentLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: