GDP: Fix performance degredation in hull transformation#3366
Merged
emma58 merged 10 commits intoPyomo:mainfrom Oct 15, 2024
Merged
GDP: Fix performance degredation in hull transformation#3366emma58 merged 10 commits intoPyomo:mainfrom
emma58 merged 10 commits intoPyomo:mainfrom
Conversation
… are both lower and upper bounds (to avoid very slow calls to Reference)
…pings (which means mappings are pretty and constraint indices are unique, hurrah)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3366 +/- ##
==========================================
- Coverage 88.63% 88.63% -0.01%
==========================================
Files 879 879
Lines 100221 100227 +6
==========================================
- Hits 88834 88833 -1
- Misses 11387 11394 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsiirola
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
In #3143, I accidentally introduced a performance degradation into
gdp.hullbecause of using aReferenceover a slice in order to map from disaggregated variables to the bound constraints for them. This PR eliminates the use of Reference, taking the hull transformation time on one model down from 150 seconds to 50 seconds.NOTE: this includes #3365 in an attempt to get tests passing
Changes proposed in this PR:
_declare_disaggregated_var_boundshelper method that actually knows whether we have both lower and upper bounds for the variables._boundConstraintscomponent on the transformation Block as we do in the mappings--the mappings can be pretty and simple ('lb' and 'ub') since they end up public-facing via theget_var_bounds_constraintmethod whereas the actual keys in_boundsConstraintscan be ugly and unique.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: