Skip to content

Pyomo.DoE Bugfix#3358

Merged
blnicho merged 2 commits intoPyomo:mainfrom
djlaky:pyomo-doe-refactor
Aug 27, 2024
Merged

Pyomo.DoE Bugfix#3358
blnicho merged 2 commits intoPyomo:mainfrom
djlaky:pyomo-doe-refactor

Conversation

@djlaky
Copy link
Copy Markdown
Contributor

@djlaky djlaky commented Aug 20, 2024

Hardcoded values have been changed.

Fixes # .

Fixes a simple bug in Pyomo.DoE where there was a hardcoded value for parameter length.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

djlaky and others added 2 commits August 20, 2024 16:50
@djlaky
Copy link
Copy Markdown
Contributor Author

djlaky commented Aug 20, 2024

@blnicho Did I miss the cut with this change? I found this today, hopefully it can make it in.

@blnicho
Copy link
Copy Markdown
Member

blnicho commented Aug 20, 2024

@djlaky we cut the 6.8.0 release this morning so this is too late for the August release. We will likely be cutting another release in about a month though.

@djlaky
Copy link
Copy Markdown
Contributor Author

djlaky commented Aug 20, 2024

@djlaky we cut the 6.8.0 release this morning so this is too late for the August release. We will likely be cutting another release in about a month though.

No problem. At least this one will be easier to review.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (5609a8a) to head (b87bdfb).
Report is 929 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3358   +/-   ##
=======================================
  Coverage   88.69%   88.69%           
=======================================
  Files         879      879           
  Lines      100218   100219    +1     
=======================================
+ Hits        88889    88891    +2     
+ Misses      11329    11328    -1
Flag Coverage Δ
linux 86.26% <100.00%> (+<0.01%) ⬆️
osx 76.03% <33.33%> (+<0.01%) ⬆️
other 86.75% <100.00%> (+<0.01%) ⬆️
win 84.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blnicho blnicho merged commit 99a9c77 into Pyomo:main Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsiirola jsiirola jsiirola approved these changes

@blnicho blnicho blnicho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@djlaky @blnicho @jsiirola @pyomo-autotest