Skip to content

Add missing main call for example file#3349

Merged
blnicho merged 1 commit intoPyomo:mainfrom
alpertoygar:fix/example-main-call
Aug 15, 2024
Merged

Add missing main call for example file#3349
blnicho merged 1 commit intoPyomo:mainfrom
alpertoygar:fix/example-main-call

Conversation

@alpertoygar
Copy link
Copy Markdown
Contributor

@alpertoygar alpertoygar commented Aug 14, 2024

Fixes # .

  • Add missing main call for the example file

Summary/Motivation:

The missing main call in the example file prevents the running of the file properly. In accordance with the other example files the main call is added.

Changes proposed in this PR:

  • Add missing main call for the example file

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@alpertoygar alpertoygar marked this pull request as ready for review August 14, 2024 13:20
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.54%. Comparing base (a777d7a) to head (d354166).
Report is 1413 commits behind head on main.

Files with missing lines Patch % Lines
...les/reactor_design/parameter_estimation_example.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3349      +/-   ##
==========================================
+ Coverage   88.53%   88.54%   +0.01%     
==========================================
  Files         868      868              
  Lines       98504    98506       +2     
==========================================
+ Hits        87210    87224      +14     
+ Misses      11294    11282      -12
Flag Coverage Δ
linux 86.05% <50.00%> (-0.01%) ⬇️
osx ?
other 83.86% <50.00%> (-2.69%) ⬇️
win 83.86% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alpertoygar
Copy link
Copy Markdown
Contributor Author

alpertoygar commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.54%. Comparing base (a777d7a) to head (d354166).
Report is 110 commits behind head on main.

Files Patch % Lines
...les/reactor_design/parameter_estimation_example.py 50.00% 1 Missing ⚠️
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

I don't know if the main call itself should be tested. If it is tested per the codebase conventions can you please direct me to an example so that I can add it.

@blnicho blnicho merged commit 123c465 into Pyomo:main Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsiirola jsiirola jsiirola approved these changes

@mrmundt mrmundt mrmundt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alpertoygar @jsiirola @mrmundt @blnicho @pyomo-autotest