Remove the _suppress_ctypes attribute from Block#3347
Merged
mrmundt merged 1 commit intoPyomo:mainfrom Aug 14, 2024
Merged
Conversation
mrmundt
approved these changes
Aug 13, 2024
Contributor
mrmundt
left a comment
mrmundt
left a comment
There was a problem hiding this comment.
I looovveee the removal of unnecessary code.
Robbybp
approved these changes
Aug 13, 2024
Contributor
Robbybp
left a comment
Robbybp
left a comment
There was a problem hiding this comment.
Make it easier to subclass pyomo types!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
This PR removes the
_suppress_ctypesattribute from Blocks. This was a hack put in 15 years ago to support PySP optimizations. It is not used anywhere in the codebase, or (to our knowledge) in any derived packages. Leaving it in was causing challenges when users were defining custom Block classesChanges proposed in this PR:
_suppress_ctypesattribute from all BlockData instancesLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: