Resolve writer performance degradation #3343
Merged
jsiirola merged 5 commits intoPyomo:mainfrom Aug 13, 2024
Merged
Conversation
mrmundt
approved these changes
Aug 13, 2024
Comment on lines
+259
to
+261
| r_o_eqns = {} | ||
| c_eqns = {} | ||
| l_eqns = {} |
Contributor
There was a problem hiding this comment.
I know this isn't an artifact of this PR, but what do r_o, c, and l stand for?
Member
Author
There was a problem hiding this comment.
See
pyomo/pyomo/repn/plugins/baron_writer.py
Lines 270 to 277 in 3f6bc13
r_o:relaxationonlyc:convexl:local
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
#3293 introduced a performance degradation into the main writers: because we no longer store the preprocessed lb / body / ub on constraints, separate calls to
lower,body, andupper(andhas_lb/has_ub) performed repeated constraint expression standardization.This PR recovers most of the degradation by making use of a single call to
ConstraintData.to_bounded_expression()Changes proposed in this PR:
evaluate_boundsoption toto_bounded_expression()to_bounded_expression()Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: