Omnibus testing / platform portability fixes#3335
Merged
blnicho merged 27 commits intoPyomo:mainfrom Aug 12, 2024
Merged
Conversation
- Silence all output generated when gathering solver availability / version information - Improve handling of version() not returning a tuple - Fix a bug where an exception raised when creating a solver caused an unhandled UnknownSolver error
mrmundt
requested changes
Aug 8, 2024
Contributor
mrmundt
left a comment
mrmundt
left a comment
There was a problem hiding this comment.
Small typo but otherwise it looks good.
| self._version_cache = (pth, version) | ||
| return self._version_cache[1] | ||
|
|
||
| def has_linear_solver(self, linear_solver): |
Contributor
There was a problem hiding this comment.
I am not thrilled with the repeat code here and in APPSI... But I get it.
mrmundt
approved these changes
Aug 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3335 +/- ##
==========================================
+ Coverage 88.52% 88.54% +0.01%
==========================================
Files 868 868
Lines 98436 98495 +59
==========================================
+ Hits 87144 87208 +64
+ Misses 11292 11287 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mrmundt
approved these changes
Aug 12, 2024
blnicho
approved these changes
Aug 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3294.
Summary/Motivation:
This fixes a number of bugs / issues motivated by #3294 (which was building on a "partially complete" platform:
cp_optimizerapparently generated an exceptionChanges proposed in this PR:
ipoptinterfaces to check for the availability of specific linear solversfreebsdpyomo help -sLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: