Kernel: fix bug in conic geomean#3310
Merged
jsiirola merged 6 commits intoPyomo:mainfrom Jul 23, 2024
Merged
Conversation
mrmundt
reviewed
Jul 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3310 +/- ##
=======================================
Coverage 88.48% 88.49%
=======================================
Files 868 868
Lines 98433 98433
=======================================
+ Hits 87103 87112 +9
+ Misses 11330 11321 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mrmundt
reviewed
Jul 17, 2024
mrmundt
approved these changes
Jul 18, 2024
jsiirola
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
pyomo.kernel.conic.primal_geomean.as_domain() does not work without a 2-character fix (dies in Mosek code). dual_geomean.as_domain() seems to have the same problem.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: