fix: Issues in SAS CAS solver interface#3309
Merged
mrmundt merged 3 commits intoPyomo:mainfrom Jul 9, 2024
Merged
Conversation
phchri
changed the title
mrmundt
approved these changes
Jul 8, 2024
jsiirola
approved these changes
Jul 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3309 +/- ##
==========================================
+ Coverage 86.46% 88.46% +1.99%
==========================================
Files 801 867 +66
Lines 96758 98214 +1456
==========================================
+ Hits 83661 86881 +3220
+ Misses 13097 11333 -1764
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Missing uuid and import MPS variable names with more than 8 characters.
Summary/Motivation:
CAS interface is not working without the uuid change. Variable length seem to exceed 8 characters sometimes, better safe than sorry.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: