Temporarily Adjust NL Writer Feasibility Tolerance within PyROS#3280
Merged
blnicho merged 8 commits intoPyomo:mainfrom Jul 9, 2024
Merged
Temporarily Adjust NL Writer Feasibility Tolerance within PyROS#3280blnicho merged 8 commits intoPyomo:mainfrom
blnicho merged 8 commits intoPyomo:mainfrom
Conversation
…f/pyomo into adjust-pyros-nl-writer-tol
jsiirola
approved these changes
Jun 28, 2024
Member
jsiirola
left a comment
jsiirola
left a comment
There was a problem hiding this comment.
This is fine, but we should add an issue to move the TOL from a module-level constant to a configuration option in the writer
blnicho
approved these changes
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
Allow PyROS to temporarily adjust the NL writer feasibility tolerance before/after solving subproblems.
This change has been instituted to circumvent encounters with
InfeasibleConstraintExceptionarising from discrepancies between the Pyomo NL writer feasibility tolerance (pyomo.repn.plugins.nl_writer.tol) and the default feasibility tolerances for NL writer-based subsolvers, such as IPOPT, for which the default value of the (unscaled) feasibility tolerance is looser.Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: