Skip to content

Formalize Testing for Forks/Branches#1294

Merged
blnicho merged 9 commits intoPyomo:masterfrom
mrmundt:formal_test
Feb 25, 2020
Merged

Formalize Testing for Forks/Branches#1294
blnicho merged 9 commits intoPyomo:masterfrom
mrmundt:formal_test

Conversation

@mrmundt
Copy link
Copy Markdown
Contributor

@mrmundt mrmundt commented Feb 12, 2020

Fixes #1274

Summary/Motivation:

As part of the attached PEP:

We will set up a single Github Action workflow that will test all branches with linux/python3.7/nightly. As this will be set up on master, it will also apply to all forks (unless the fork owner changes the configuration locally). This will provide quick "sanity tests" for ongoing development.

NOTE (@jsiirola @carldlaird ): This test does NOT automatically run when Pyomo is forked. The user who has forked the repository needs to go to the Actions tab on their new fork to enable actions.

Changes proposed in this PR:

  • Add Github Workflow that runs the linux/py3.7/nightly test suite for every "push"

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 12, 2020 •
edited
Loading

Codecov Report

Merging #1294 into master will increase coverage by 5.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1294      +/-   ##
==========================================
+ Coverage   65.48%   70.54%   +5.05%     
==========================================
  Files         474      534      +60     
  Lines       75270    81013    +5743     
==========================================
+ Hits        49290    57147    +7857     
+ Misses      25980    23866    -2114
Impacted Files Coverage Δ
pyomo/solvers/plugins/solvers/cplex_direct.py 12.4% <0%> (-0.14%) ⬇️
pyomo/core/kernel/matrix_constraint.py 100% <0%> (ø) ⬆️
...amples/gdp/strip_packing/strip_packing_concrete.py 100% <0%> (ø) ⬆️
pyomo/contrib/gdpbb/test_GDPbb_deprecate.py 100% <0%> (ø) ⬆️
pyomo/core/kernel/conic.py 100% <0%> (ø) ⬆️
...omo/core/kernel/piecewise_library/transforms_nd.py 100% <0%> (ø) ⬆️
examples/gdp/small_lit/ex_633_trespalacios.py 70.58% <0%> (ø) ⬆️
pyomo/common/deprecation.py 100% <0%> (ø) ⬆️
pyomo/pysp/annotations.py 100% <0%> (ø) ⬆️
pyomo/core/base/util.py 100% <0%> (ø) ⬆️
... and 230 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2689f6...7393698. Read the comment docs.

@mrmundt mrmundt mentioned this pull request Feb 13, 2020
Merged
@mrmundt
Copy link
Copy Markdown
Contributor Author

mrmundt commented Feb 13, 2020

@jsiirola - I incorporated the changes from #1276 into this one.

@mrmundt
Copy link
Copy Markdown
Contributor Author

mrmundt commented Feb 20, 2020

@jsiirola - What else do we need to add to this?

qtothec
qtothec reviewed Feb 20, 2020
View reviewed changes
Comment thread .github/workflows/push_master_test.yml
@blnicho blnicho merged commit 49e2ff1 into Pyomo:master Feb 25, 2020
@jsiirola jsiirola mentioned this pull request Feb 25, 2020
Closed
@mrmundt mrmundt mentioned this pull request Feb 26, 2020
Merged
@mrmundt mrmundt deleted the formal_test branch February 27, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsiirola jsiirola jsiirola approved these changes

@michaelbynum michaelbynum michaelbynum approved these changes

+1 more reviewer

@qtothec qtothec qtothec left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[PEP] Formalize repo management / testing process

5 participants

@mrmundt @jsiirola @qtothec @michaelbynum @blnicho