Codecov Report

Merging #1281 into master will decrease coverage by 2.45%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1281      +/-   ##
=========================================
- Coverage   70.95%   68.5%   -2.46%     
=========================================
  Files         534     474      -60     
  Lines       81004   75733    -5271     
=========================================
- Hits        57479   51880    -5599     
- Misses      23525   23853     +328

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f1182...e557faf. Read the comment docs.

@jsiirola - Fun fact: I checked and the same issue was happening with Ubuntu and Windows. I have fixed the issues.
In addition, I tried a one-older GAMS distribution for Mac (29.1.0). It installs and runs without a license file, so I've changed the workflow to incorporate this while we wait on #1280.

We are getting closer. We are still seeing:

test_file_removal_py (pyomo.solvers.tests.checks.test_GAMS.GAMSTests) ... SKIP: The 'gams' python bindings are not available

It looks like we can install them with:

cd gams/gams29.1_linux_x64_64_sfx/apifiles/Python/api && python setup.py install

(substituting api_34, pai_36, and api_37 for those versions of Python... 3.5 and 3.8 might be able to get away with (automatically) rebuilding the bindings drom the api directory?)

We are getting closer. We are still seeing:

test_file_removal_py (pyomo.solvers.tests.checks.test_GAMS.GAMSTests) ... SKIP: The 'gams' python bindings are not available

It looks like we can install them with:

cd gams/gams29.1_linux_x64_64_sfx/apifiles/Python/api && python setup.py install

(substituting api_34, pai_36, and api_37 for those versions of Python... 3.5 and 3.8 might be able to get away with (automatically) rebuilding the bindings drom the api directory?)

Another one that is happening for all OS'! Interesting point there - you can just give it the flag -noCheck to power through without worrying about the Python version. The original api folder looks like it's intended for Py27. I tried python setup.py install -noCheck on my local machine (which runs Py37) and it built, so it might work out for Py35/38.

I think, in terms of "closeness", we might want to try the api_34 bindings for Py35 and api_37 for Py38. Thoughts?

I think, in terms of "closeness", we might want to try the api_34 bindings for Py35 and api_37 for Py38. Thoughts?

No - the code for the various versions should be the same. The difference is how the compiled module libraries are linked. So, api_34 should only work for Python 3.4.x. When we use api's setup.py for other python versions, it should be recognizing that the Python version is different and regenerating / recompiling the libraries from scratch (the point of api_3? is that on those platforms, no compilation is necessary).

I think, in terms of "closeness", we might want to try the api_34 bindings for Py35 and api_37 for Py38. Thoughts?

No - the code for the various versions should be the same. The difference is how the compiled module libraries are linked. So, api_34 should only work for Python 3.4.x. When we use api's setup.py for other python versions, it should be recognizing that the Python version is different and regenerating / recompiling the libraries from scratch (the point of api_3? is that on those platforms, no compilation is necessary).

Gotcha! Makes sense to me. I'll work on that.

We are getting closer. We are still seeing:

test_file_removal_py (pyomo.solvers.tests.checks.test_GAMS.GAMSTests) ... SKIP: The 'gams' python bindings are not available

It looks like we can install them with:

cd gams/gams29.1_linux_x64_64_sfx/apifiles/Python/api && python setup.py install

(substituting api_34, pai_36, and api_37 for those versions of Python... 3.5 and 3.8 might be able to get away with (automatically) rebuilding the bindings drom the api directory?)

@jsiirola - It turns out, this issue exists in ALL of our testing suites. If you look at Appveyor, Jenkins, and Travis, the GAMS python binding tests are skipped in every single one. I am experimenting with getting it working on Ubuntu first (I was able to get them working on my local RHEL).

@jsiirola @allevin @blnicho - This is finally complete. The Python bindings don't work for Python 3.5 and 3.8 on Windows, but that's it. Everything else is fine.

Related to this: It turns out there is (at least on Windows) a bug with conda that occurs when a package fails to install. I submitted an issue to conda for it.