Skip to content

changing NoArgumentGiven to a class#1236

Merged
blnicho merged 2 commits intoPyomo:masterfrom
qtothec:not_giving_arguments
Dec 18, 2019
Merged

changing NoArgumentGiven to a class#1236
blnicho merged 2 commits intoPyomo:masterfrom
qtothec:not_giving_arguments

Conversation

@qtothec
Copy link
Copy Markdown
Contributor

@qtothec qtothec commented Dec 18, 2019

Summary/Motivation:

Changing NoArgumentGiven to a class. Standardizing Param to use this.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 18, 2019 •
edited
Loading

Codecov Report

Merging #1236 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1236      +/-   ##
==========================================
- Coverage   70.98%   70.83%   -0.15%     
==========================================
  Files         534      475      -59     
  Lines       81688    76879    -4809     
==========================================
- Hits        57987    54461    -3526     
+ Misses      23701    22418    -1283
Impacted Files Coverage Δ
pyomo/common/modeling.py 100% <100%> (+6.66%) ⬆️
pyomo/core/base/param.py 82.03% <100%> (-0.05%) ⬇️
pyomo/pysp/plugins/csvsolutionwriter.py 24.24% <0%> (-72.73%) ⬇️
pyomo/pysp/solvers/benders.py 11.34% <0%> (-70.45%) ⬇️
pyomo/solvers/plugins/solvers/direct_solver.py 12.22% <0%> (-70%) ⬇️
pyomo/pysp/lagrangeMorePR.py 5.54% <0%> (-68.98%) ⬇️
pyomo/solvers/plugins/solvers/CPLEX.py 20.7% <0%> (-64.19%) ⬇️
pyomo/solvers/plugins/solvers/cplex_direct.py 12.54% <0%> (-59.93%) ⬇️
pyomo/solvers/plugins/solvers/gurobi_direct.py 12.82% <0%> (-58.18%) ⬇️
pyomo/solvers/plugins/solvers/GUROBI.py 31.61% <0%> (-57.75%) ⬇️
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b949e...aed48b6. Read the comment docs.

@blnicho blnicho merged commit 95cdca3 into Pyomo:master Dec 18, 2019
@qtothec qtothec deleted the not_giving_arguments branch December 18, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blnicho blnicho blnicho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qtothec @blnicho