Skip to content

[WIP] Try out Github Actions#1194

Closed
qtothec wants to merge 15 commits intomasterfrom
try-github-actions
Closed

[WIP] Try out Github Actions#1194
qtothec wants to merge 15 commits intomasterfrom
try-github-actions

Conversation

@qtothec
Copy link
Copy Markdown
Contributor

@qtothec qtothec commented Nov 19, 2019

Summary/Motivation:

Trying out Github Actions

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@qtothec
Copy link
Copy Markdown
Contributor Author

qtothec commented Nov 19, 2019

I am not setting up the testing execution correctly somehow, but this seems rather promising.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 28, 2019

Codecov Report

Merging #1194 into master will increase coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1194      +/-   ##
==========================================
+ Coverage   70.55%   70.96%   +0.41%     
==========================================
  Files         534      534              
  Lines       81675    81679       +4     
==========================================
+ Hits        57623    57965     +342     
+ Misses      24052    23714     -338
Impacted Files Coverage Δ
pyomo/pysp/plugins/interscenario.py 0% <0%> (ø) ⬆️
pyomo/pysp/scenariotree/manager.py 88.15% <0%> (+0.06%) ⬆️
pyomo/scripting/driver_help.py 32.76% <0%> (+1.41%) ⬆️
pyomo/solvers/plugins/solvers/cplex_persistent.py 40.35% <0%> (+1.75%) ⬆️
pyomo/neos/kestrel.py 80.2% <0%> (+7.81%) ⬆️
pyomo/solvers/plugins/solvers/cplex_direct.py 72.47% <0%> (+59.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5300a...bbf1b4d. Read the comment docs.

@carldlaird
Copy link
Copy Markdown
Member

@qtothec This looks interesting. Is this WIP right now?

@qtothec qtothec changed the title Try out Github Actions [WIP] Try out Github Actions Nov 29, 2019
@qtothec
Copy link
Copy Markdown
Contributor Author

qtothec commented Nov 29, 2019

@carldlaird Yes, but I'll probably need some help getting it operational. Plus we ought to have a discussion around how it would fit into the overall testing infrastructure.

@blnicho
Copy link
Copy Markdown
Member

blnicho commented Dec 11, 2019

It looks like this is revealing an issue in some of the trust region tests, they seem to implicitly require Ipopt.

@blnicho
Copy link
Copy Markdown
Member

blnicho commented Dec 11, 2019

@mrmundt @allevin @qtothec it passed!

@mrmundt
Copy link
Copy Markdown
Contributor

mrmundt commented Dec 11, 2019

@blnicho @qtothec @allevin - I KNOW! I might have been impatiently waiting for your PR to be merged. Thank you!

@blnicho
Copy link
Copy Markdown
Member

blnicho commented Dec 11, 2019

It was surprisingly fast too, 2.5 minutes to run 6962 tests (1581 skipped).

@allevin
Copy link
Copy Markdown
Contributor

allevin commented Dec 11, 2019

Next steps are to try it on other machines (Mac & WIn), then bump up to matrix builds across python versions.

@blnicho
Copy link
Copy Markdown
Member

blnicho commented Dec 11, 2019

Ok, I'm really impressed now. Only 3.5 minutes to complete "slim" test suites on Python 2.7, 3.5, 3.6, and 3.7 on Linux

@mrmundt
Copy link
Copy Markdown
Contributor

mrmundt commented Dec 11, 2019

Impressively quick. It's amazing. I'm about to start a run for MacOS with just Python 2.7. Let's see if the trend of success continues!

@qtothec
Copy link
Copy Markdown
Contributor Author

qtothec commented Dec 11, 2019

This is separate from getting this to work, but is there a way to manage the console output so that you don't have to scroll past pages of successful tests to get to the errors?

@blnicho
Copy link
Copy Markdown
Member

blnicho commented Dec 11, 2019

There is a lower verbosity level for nosetests but I think in most cases we would want to be able to see exactly which tests were run instead of ". . . . . . S . . . F"

@allevin
Copy link
Copy Markdown
Contributor

allevin commented Dec 11, 2019

I think we can take the -v off the test run to reduce the output to just the errors...

@mrmundt
Copy link
Copy Markdown
Contributor

mrmundt commented Dec 13, 2019

@jsiirola has pointed us to the fact that there is an old editor on macOS's named "pico" - which is triggering the pico tests to start, and thus, all fail. We'll need to address this somehow.

@qtothec
Copy link
Copy Markdown
Contributor Author

qtothec commented Dec 17, 2019

Replacing this with separate PRs for different distributions.

@qtothec qtothec closed this Dec 17, 2019
@qtothec qtothec deleted the try-github-actions branch December 17, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants