Skip to content

fix: Remove stale sticker-type todo#3121

Merged
Paillat-dev merged 2 commits into
Pycord-Development:masterfrom
ToothyDev:fix/remove-sticker-type-todo
Feb 28, 2026
Merged

fix: Remove stale sticker-type todo#3121
Paillat-dev merged 2 commits into
Pycord-Development:masterfrom
ToothyDev:fix/remove-sticker-type-todo

Conversation

@ToothyDev

Copy link
Copy Markdown
Contributor

Summary

This is an old todo comment that doesn't seem to be relevant anymore, see attached issue
Fixes #1918

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@ToothyDev
ToothyDev requested a review from a team as a code owner February 23, 2026 14:28
@pycord-app

pycord-app Bot commented Feb 23, 2026

Copy link
Copy Markdown

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3121/head:pr-3121
git checkout pr-3121

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3121/head

Paillat-dev
Paillat-dev previously approved these changes Feb 23, 2026
plun1331
plun1331 previously approved these changes Feb 23, 2026
@ToothyDev

Copy link
Copy Markdown
Contributor Author

Good job plun /s

@plun1331

Copy link
Copy Markdown
Member

Good job plun /s

it's your checks failing, I didn't make the pr :p

Comment thread .github/workflows/lib-checks.yml Outdated
@Paillat-dev
Paillat-dev merged commit 2294d0a into Pycord-Development:master Feb 28, 2026
5 of 8 checks passed
@ToothyDev
ToothyDev deleted the fix/remove-sticker-type-todo branch February 28, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve handling of unknown sticker format types if possible

3 participants