fix: Add missing Thread mapping for get_or_fetch#3101
Merged
Paillat-dev merged 4 commits intoFeb 12, 2026
Conversation
Remove several unused imports (MessageType, try_enum, Member, MaxConcurrency) and tidy up multiline lambda/typing checks in commands core. Add Thread to utils._get_getter_fetcher_map with the same get_channel/fetch_channel getter and fetcher, enabling Thread resolution support. Changes are primarily import cleanup, minor refactors for readability, and adding Thread handling.
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3101/head:pr-3101
git checkout pr-3101This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3101/head |
Paillat-dev
changed the title
Paillat-dev
reviewed
Feb 12, 2026
Paillat-dev
left a comment
Paillat-dev
left a comment
Member
There was a problem hiding this comment.
Other than the comment, tested and lgtm
Paillat-dev
requested changes
Feb 12, 2026
Paillat-dev
left a comment
Paillat-dev
left a comment
Member
There was a problem hiding this comment.
Ik its dumb put please separate this in two prs.
Contributor
Author
its just pre commit |
Member
|
@Lumabots All of it ? yes |
Contributor
Author
|
, only part i changed is the 2 lines to add thread |
Paillat-dev
changed the title
Thread mapping for get_or_fetch
Paillat-dev
changed the title
Thread mapping for get_or_fetchThread mapping for get_or_fetch
Paillat-dev
approved these changes
Feb 12, 2026
Paillat-dev
enabled auto-merge (squash)
February 12, 2026 17:36
Paillat-dev
disabled auto-merge
February 12, 2026 17:39
Paillat-dev
merged commit Feb 12, 2026
13f9bbc
into
Pycord-Development:master
29 of 31 checks passed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove several unused imports (MessageType, try_enum, Member, MaxConcurrency) and tidy up multiline lambda/typing checks in commands core. Add Thread to utils._get_getter_fetcher_map with the same get_channel/fetch_channel getter and fetcher, enabling Thread resolution support. Changes are primarily import cleanup, minor refactors for readability, and adding Thread handling.
Information
get_or_fetchallowsdiscord.Threadbut doesn't handle it. #3100examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.