Skip to content

fix: 🐛 Handle python 3.12+ TypeAliasType in Option parsing#2952

Merged
Lulalaby merged 3 commits into
masterfrom
fix/type-alias-cmd-options
Oct 20, 2025
Merged

fix: 🐛 Handle python 3.12+ TypeAliasType in Option parsing#2952
Lulalaby merged 3 commits into
masterfrom
fix/type-alias-cmd-options

Conversation

@Paillat-dev

@Paillat-dev Paillat-dev commented Oct 12, 2025

Copy link
Copy Markdown
Member

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev
Paillat-dev requested a review from a team as a code owner October 12, 2025 21:10
@pycord-app

pycord-app Bot commented Oct 12, 2025

Copy link
Copy Markdown

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/2952/head:pr-2952
git checkout pr-2952

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/2952/head

@Paillat-dev
Paillat-dev requested review from a team as code owners October 12, 2025 21:14
@Paillat-dev Paillat-dev linked an issue Oct 12, 2025 that may be closed by this pull request
3 tasks
Soheab
Soheab previously approved these changes Oct 12, 2025

@Soheab Soheab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested code in the issue.

@Soheab

This comment has been minimized.

@Soheab Soheab added the on hold label Oct 17, 2025

@Lumabots Lumabots left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works it works
cant wait for option rewrite tho

@Lulalaby
Lulalaby merged commit 72b6e05 into master Oct 20, 2025
28 checks passed
@Lulalaby
Lulalaby deleted the fix/type-alias-cmd-options branch October 20, 2025 10:08
Paillat-dev added a commit to Pycord-Development/pycord-next that referenced this pull request Oct 26, 2025
…d-Development#2952)

* 🐛 Handle python 3.12+ `TypeAliasType` in `Option` parsing

* 📝 CHANGELOG.md

---------

Signed-off-by: Paillat <[email protected]>

(cherry picked from commit 72b6e05)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.12+ type keyword not supported in command types

4 participants