fix: 🐛 Fix TypeError when typing ui.Select#2943
Merged
Merged
Conversation
Paillat-dev
requested review from
Icebluewolf,
Lulalaby,
Lumabots and
plun1331
October 2, 2025 08:09
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/2943/head:pr-2943
git checkout pr-2943This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/2943/head |
Paillat-dev
force-pushed
the
fix/type-error-select
branch
from
October 2, 2025 08:11
b68ce72 to
bddb527
Compare
Lumabots
reviewed
Oct 2, 2025
Lumabots
left a comment
Lumabots
left a comment
Contributor
There was a problem hiding this comment.
lgtm as long as its ok to bump the requierment
Lumabots
approved these changes
Oct 2, 2025
Lulalaby
approved these changes
Oct 2, 2025
Contributor
|
could we merge this asap ? as it fix a breaking change ? (even tho its still breaking in a way with the changement of the requirement |
Member
Author
|
The requirement isn't breaking because currently py-cord sub-demendencies require a higher typing_extensions version afaik |
Paillat-dev
requested review from
DA-344
and removed request for
Icebluewolf and
plun1331
October 8, 2025 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.